Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23844 )

Change subject: [tools] Add --preserve_table_ids flag to unsafe_rebuild
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23844/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23844/6//COMMIT_MSG@18
PS6, Line 18:  The flag is disabled
            : by default to maintain backward compatibility.
I'd rather enable this behavior by default.  I don't think that there is a 
meaningful use case that would require the regenerated table identifiers to be 
different.  The prior behavior of the tool was rather a defect, not a feature.



--
To view, visit http://gerrit.cloudera.org:8080/23844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ae4353564922312d646f0323271d804e32e3b0d
Gerrit-Change-Number: 23844
Gerrit-PatchSet: 6
Gerrit-Owner: Yan-Daojiang <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <[email protected]>
Gerrit-Comment-Date: Fri, 13 Mar 2026 02:55:28 +0000
Gerrit-HasComments: Yes

Reply via email to