Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24096 )
Change subject: KUDU-3692 Export entity attributes as Prometheus labels ...................................................................... Patch Set 4: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/24096/2/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/24096/2/src/kudu/util/metrics.cc@42 PS2, Line 42: labe > Thanks for the suggestion. OK, this make sense to me. We can decide on the default value for the metrics_prometheus_use_entity_labels flag later (probably, closer to the date of Kudu 1.19.0 release) and make corresponding updates in a separate changelist, if necessary. http://gerrit.cloudera.org:8080/#/c/24096/3/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/24096/3/src/kudu/util/metrics.cc@1226 PS3, Line 1226: } else { : // Legacy format: no labels, space after comma, _sum/_count have no labels. > Good catch! Great, thank you for addressing this. http://gerrit.cloudera.org:8080/#/c/24096/3/src/kudu/util/prometheus_writer.cc File src/kudu/util/prometheus_writer.cc: http://gerrit.cloudera.org:8080/#/c/24096/3/src/kudu/util/prometheus_writer.cc@91 PS3, Line 91: > Good point, thanks for raising this. Thank you for addressing this point; PS4 looks good to me as is. -- To view, visit http://gerrit.cloudera.org:8080/24096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I690918d06f19c393369b8fc43c3ec90dd2231d3d Gerrit-Change-Number: 24096 Gerrit-PatchSet: 4 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2026 20:34:04 +0000 Gerrit-HasComments: Yes
