Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24086 )
Change subject: KUDU-3749 Fix range key hex encoding ...................................................................... KUDU-3749 Fix range key hex encoding ksck, auto-rebalancer, and PartitionKey::DebugString() serialize range keys into hex strings. Make the encoding consistent and safe by treating each byte as unsigned before widening, avoiding signed-char sign extension. Change-Id: I6d7f0304c0f5bb88ae79a28c740a8791c2eaa03a Reviewed-on: http://gerrit.cloudera.org:8080/24086 Reviewed-by: Zoltan Chovan <[email protected]> Tested-by: Zoltan Chovan <[email protected]> Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> --- M src/kudu/common/partition.cc M src/kudu/master/auto_rebalancer.cc M src/kudu/tools/ksck.cc M src/kudu/tools/rebalancer_tool-test.cc M src/kudu/util/hexdump.cc M src/kudu/util/hexdump.h 6 files changed, 35 insertions(+), 33 deletions(-) Approvals: Zoltan Chovan: Looks good to me, approved; Verified Marton Greber: Looks good to me, but someone else must approve; Verified -- To view, visit http://gerrit.cloudera.org:8080/24086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6d7f0304c0f5bb88ae79a28c740a8791c2eaa03a Gerrit-Change-Number: 24086 Gerrit-PatchSet: 6 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
