Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24092 )
Change subject: [fs] add metrics for untracked orphaned blocks ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/fs/log_block_manager.cc@2529 PS2, Line 2529: help nit: held ? http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/fs/log_block_manager.cc@2530 PS2, Line 2530: lyring nit: lying ? http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/fs/log_block_manager.cc@3363 PS2, Line 3363: // RemoveBlockIdsFromMetadata writes records in the same order as clbs, Does this assumption hold for LogBlockContainerRdbMeta? http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metadata-test.cc File src/kudu/tablet/tablet_metadata-test.cc: http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metadata-test.cc@441 PS2, Line 441: TEST_F(TestTabletMetadata, TestOrphanBlockDeletionFailed) { Can we also assert orphaned_block_cleanup_failures_bytes in this test? http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metadata.cc@601 PS2, Line 601: auto bm_size = fs_manager()->block_manager(); do we need this declaration here? can't we reuse the above declared bm? http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metadata.cc@623 PS2, Line 623: // Regardless of whether we deleted all the blocks or not, remove them from : // the orphaned blocks list. If we failed to delete the blocks due to : // hardware issues, there's not much we can do and we assume the disk isn't : // coming back. At worst, this leaves some untracked orphaned blocks. Maybe I dont have the complete picture yet, but doesnt this contradict that above LOG_WITH_PREDIX message about "...will be retried on the next metadata flush..." http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metrics.cc@247 PS2, Line 247: nit: extra new line? -- To view, visit http://gerrit.cloudera.org:8080/24092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id386d9fc8d0900839e229e66772f35299b3ef2e9 Gerrit-Change-Number: 24092 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2026 12:36:57 +0000 Gerrit-HasComments: Yes
