Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24085 )
Change subject: KUDU-3729 Add flag to avoid moving leader replicas ...................................................................... Patch Set 2: Thanks for the patch! Not sure if my understanding is correct but the implementation doesn't quite match the description: FindReplicas() already avoids leader replicas — it only falls back to leaders when no follower alternative exists for a given (table, from_server, to_server) triplet. So any leader moves that reach PrioritizeMovesAvoidingLeaders() are already unavoidable last-resort moves. What the new function actually does is reorder a list of already-committed moves so followers are submitted first to ExecuteMoves() — but since all moves in the batch execute regardless, the only real effect is submission order within a single round. What do you think, am I missing something here? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/24085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b56ae5ef8db5fe15ab25df1d1cebe84fd3b8f2c Gerrit-Change-Number: 24085 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2026 13:31:17 +0000 Gerrit-HasComments: No
