Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24121 )
Change subject: [metrics] Export hostname as a Prometheus label when entity labels are enabled ...................................................................... Patch Set 3: (1 comment) Done http://gerrit.cloudera.org:8080/#/c/24121/2/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/24121/2/src/kudu/util/metrics-test.cc@1479 PS2, Line 1479: rapidjson::Document d; > The comment claims coverage for the server entity type but the test doesn't Added server entity to PrometheusHostnameLabelTest and PrometheusHostnameLabelLegacyNoEffect. Also added the server_test_counter metric definition. -- To view, visit http://gerrit.cloudera.org:8080/24121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43b4c8ea5736e99c20b25a2ffea3c6c8dcb9d27e Gerrit-Change-Number: 24121 Gerrit-PatchSet: 3 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Sat, 21 Mar 2026 09:56:34 +0000 Gerrit-HasComments: Yes
