Hello Marton Greber, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24134
to look at the new patch set (#2).
Change subject: [fs] fix partial blocks deletion case in rocksdb
......................................................................
[fs] fix partial blocks deletion case in rocksdb
This fixes a bug in rocksdb block deletion logic where only a partial
number of total blocks are successfully deleted, but the function
returns total number of blocks as 'deleted' inside the out parameter
i.e., 'deleted_block_ids'. However, the same case is handled in native
container by resizing the out parameter to correct number of blocks that
were deleted successfully, at the end of function scope.
The fix is to apply the same scoped cleanup logic for rocksdb method as
well by resizing the 'deleted_block_ids' out parameter with total number
of committed blocks. A unit test is added to verify the same.
Change-Id: Ifb553fbf9a88f0cdb392f926289bbdf5f18b5d29
---
M src/kudu/fs/dir_manager.h
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
4 files changed, 120 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/24134/2
--
To view, visit http://gerrit.cloudera.org:8080/24134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb553fbf9a88f0cdb392f926289bbdf5f18b5d29
Gerrit-Change-Number: 24134
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
