Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24152 )
Change subject: fix flaky TestTableStatistics stat assertions ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24152/1/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/24152/1/python/kudu/tests/test_client.py@1286 PS1, Line 1286: def test_on_disk_size_is_valid(self): : size = self._wait_for_stat(self.client, self.ex_table, : lambda s: s.on_disk_size, min_value=0) : self.assertGreaterEqual(size, 0, : "on_disk_size still -1 after waiting for heartbeat propagation") : : def test_live_row_count_is_valid(self): : count = self._wait_for_stat(self.client, self.ex_table, : lambda s: s.live_row_count, min_value=0) : self.assertGreaterEqual(count, 0, : "live_row_count sti Are you 100% sure it is -1? Please use {count} instead of -1. Maybe someone messed up on the c++ side and it's actually negative row count and your message is completely misleading. -- To view, visit http://gerrit.cloudera.org:8080/24152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d5cd69802ec2139e8df4c87903e3c6196e26ae3 Gerrit-Change-Number: 24152 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 31 Mar 2026 10:15:00 +0000 Gerrit-HasComments: Yes
