Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24139 )
Change subject: docs: add Flink replication guide ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24139/2/docs/kudu_flink_replication.adoc File docs/kudu_flink_replication.adoc: http://gerrit.cloudera.org:8080/#/c/24139/2/docs/kudu_flink_replication.adoc@377 PS2, Line 377: Writer parameters > Do you think rest of the parameters (writer.ignoreNotFound and writer.ignor Done http://gerrit.cloudera.org:8080/#/c/24139/2/docs/kudu_flink_replication.adoc@389 PS2, Line 389: | `writer.maxBufferSize` | No | 1000 : | Maximum number of operations buffered in the Kudu write session. > This doesn't align with what is written in java file documentation: Actually it looks like the javadoc was misleading. Thanks for pointing this out! I've posted the javadoc fix here: https://gerrit.cloudera.org/#/c/24157/ http://gerrit.cloudera.org:8080/#/c/24139/2/docs/kudu_flink_replication.adoc@694 PS2, Line 694: eady state (between discovery cycles), `pendingCount`, `unassignedCount`, and > Will this be added as part of a separate change? Yes, this is covered in a separate change already up for review: https://gerrit.cloudera.org/#/c/24127/ I'd like to keep that patch clean. -- To view, visit http://gerrit.cloudera.org:8080/24139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I684d608165af636bd4a799351926b68322469218 Gerrit-Change-Number: 24139 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 31 Mar 2026 12:31:17 +0000 Gerrit-HasComments: Yes
