Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG@14 PS1, Line 14: The confusion likely stems from the parameter name in the Flink : connector (KuduWriterConfig.maxBufferSize), which implies a byte : quantity, while the connector's own source comment clarifies: : "Reference from AsyncKuduSession mutationBufferMaxOps 1000." > Why not change the name everywhere so that it is no more confusing? Even wi The naming confusion originates from flink-connector-kudu's KuduWriterConfig.maxBufferSize, which this code calls directly. Renaming only the CLI parameter in the replication layer would create an asymmetry with the underlying API. Filed FLINK-39374 to rename the field at the source; the replication code can follow up in a subsequent patch. In the meantime, the test value has been corrected from 5242880 (clearly written assuming bytes) to a realistic operation count. http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java File java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java: http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java@155 PS1, Line 155: <li>{@code writer.maxBufferSize} (optional) – maximum number of operations buffered in the : * Kudu write session (maps to {@code mutationBufferMaxOps})</li> > Do you think TestReplicationConfigParser.java also needs to change here: Although this is only parameter test, changed to a sensible value. -- To view, visit http://gerrit.cloudera.org:8080/24157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a Gerrit-Change-Number: 24157 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 01 Apr 2026 08:46:39 +0000 Gerrit-HasComments: Yes
