Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24160 )
Change subject: KUDU-3758 avoid TransferPayload copying for
CreateForCall{Request,Response}
......................................................................
KUDU-3758 avoid TransferPayload copying for CreateForCall{Request,Response}
Even if copying of Slice objects is shallow (the underlying memory isn't
copied, just the pointer and the size are copied), it makes sense to
avoid heap memory allocation and copying of Slice objects themselves.
The latter happens when there are more than two side-cars in per RPC, so
TransferPayload (boost::container::small_vector<Slice, 4> typedef)
starts allocating its elements on the heap.
Change-Id: Ia26e1a18fbb903a4df2ab7b20549fca3c2b06ad2
Reviewed-on: http://gerrit.cloudera.org:8080/24160
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
---
M src/kudu/rpc/connection.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26e1a18fbb903a4df2ab7b20549fca3c2b06ad2
Gerrit-Change-Number: 24160
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
