Yan-Daojiang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24158 )

Change subject: [tablet] optimize MemRowSet scan to single-pass changelist 
application
......................................................................


Patch Set 2:

Patch Set 2:

Thanks for the thorough review! All five suggested tests have been added:

TestPartialProjectionWithSnapshotBetweenMutations — scans at an
intermediate MVCC snapshot with partial projections (excluding col_a
and excluding col_b respectively). The test includes mixed changelists
touching both projected and non-projected columns. Also covers the
DELETE + REINSERT boundary with an intermediate snapshot.

TestPartialProjectionWithSnapToExclude — builds a 7-snapshot timeline
(INSERT, mixed UPDATE, pure-non-projected UPDATE, mixed UPDATE, DELETE,
REINSERT) and scans with [snap_exclude, snap_include) windows using a
(key, col_a) projection. Covers 6 single-step windows, 7 wider windows,
and empty-range checks.

TestPartialProjectionMultipleRows — inserts 5 rows with varying mutation
chains (no-op, single-column UPDATE, mixed-column UPDATE, multi-mutation
with nullable NULL, UPDATE + DELETE + REINSERT) and scans with three
different partial projections (key+col_a, key+col_b, key+col_c).

TestKeyOnlyProjection — scans with CreateKeyProjection() after mutations
and after DELETE + REINSERT, verifying the scan completes cleanly when
every column update is outside the projection.

TestIncludeDeletedRowsWithPartialProjection — 4 rows with different life
cycles. Three scans: a baseline without include_deleted_rows, one with
include_deleted_rows=true using a (key, col_a) projection, and one
adding the IS_DELETED virtual column to verify deletion status.


--
To view, visit http://gerrit.cloudera.org:8080/24158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ccdfcf207680261907d025b64a9b046bb108f13
Gerrit-Change-Number: 24158
Gerrit-PatchSet: 2
Gerrit-Owner: Yan-Daojiang <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Yan-Daojiang <[email protected]>
Gerrit-Comment-Date: Fri, 10 Apr 2026 15:59:12 +0000
Gerrit-HasComments: No

Reply via email to