Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24278 )
Change subject: KUDU-3693: Add bearer token auth for Prometheus ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24278/2/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/24278/2/src/kudu/server/webserver-test.cc@494 PS2, Line 494: IPMode::IPV4 is there a particular reason why we're not testing for IPV6? http://gerrit.cloudera.org:8080/#/c/24278/2/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/24278/2/src/kudu/server/webserver.cc@640 PS2, Line 640: CRYPTO_memcmp According to https://man.archlinux.org/man/libressl-CRYPTO_memcmp.3.en was introduced in OpenSSL 1.0.1d, but in our CMakeLists.txt we declare 1.0.0 as a minimum, so maybe this could break on older versions? Maybe Alexey could clarify on if this could be a problem or not. http://gerrit.cloudera.org:8080/#/c/24278/2/src/kudu/server/webserver_options.cc File src/kudu/server/webserver_options.cc: http://gerrit.cloudera.org:8080/#/c/24278/2/src/kudu/server/webserver_options.cc@103 PS2, Line 103: DEFINE_string(webserver_prometheus_token, "", would a GROUP_FLAG_VALIDATOR make sense here to check if webserver_spnego is enabled? Otherwise there is not much sense in setting this flag -- To view, visit http://gerrit.cloudera.org:8080/24278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8169196a2c49d64865095f3bc6da1d3bfbcecfb Gerrit-Change-Number: 24278 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 14:39:58 +0000 Gerrit-HasComments: Yes
