Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24289 )
Change subject: [tools] perf loadgen: support configurable column counts for auto-created table ...................................................................... [tools] perf loadgen: support configurable column counts for auto-created table `kudu perf loadgen` always creates a fixed 3-column table (`key INT64 PK`, `int_val INT32`, `string_val STRING`) when --table_name is not provided. Benchmarking wide-row workloads currently requires pre-creating a table out-of-band and pointing loadgen at it via --table_name, which is inconvenient for parameter sweeps over column count. This patch adds two flags: --table_num_int_columns (default 1) --table_num_string_columns (default 1) When both default to 1 the auto-created schema is byte-for-byte identical to before (column names `int_val`, `string_val` are preserved). Setting either to N >= 2 produces N suffix-numbered columns of that type; 0 omits that column type entirely. This patch is intentionally limited to INT32 / STRING column counts. DECIMAL precision, VARCHAR length, and encoding are out of scope; users needing those should pre-create a table and pass --table_name. They are noted as possible follow-ups. Change-Id: I5a1581a7d6056fcb1d7435f29d4670bff68fb147 Reviewed-on: http://gerrit.cloudera.org:8080/24289 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_perf.cc 2 files changed, 215 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5a1581a7d6056fcb1d7435f29d4670bff68fb147 Gerrit-Change-Number: 24289 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]>
