Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24290 )
Change subject: [tools] fix `table add_column` failing to add DECIMAL/VARCHAR columns ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: Verified+1 > > (1 comment) > > LGTM, just one tiny nit Thanks for the review, done! http://gerrit.cloudera.org:8080/#/c/24290/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/24290/1/src/kudu/tools/tool_action_table.cc@2194 PS1, Line 2194: > nit: maybe, add DECIMAL and VARCHAR into the list as well? Done -- To view, visit http://gerrit.cloudera.org:8080/24290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cf3cc23d1bc972c48bbc4a579503b13aad47655 Gerrit-Change-Number: 24290 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 12 May 2026 01:09:07 +0000 Gerrit-HasComments: Yes
