Marton Greber has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24278 )

Change subject: KUDU-3693: Add bearer token auth for Prometheus
......................................................................


Patch Set 5:

Thanks Alexey for the review!
Yes, I did reconsider the fact that when bearer token authentication is 
enabled, the Prometheus endpoints become accessible exclusively with a bearer 
token. If we tied the bearer token option to SPNEGO, then users who do not use 
Prometheus would be exposed to a flag that is not relevant to them.
It is also a valid concern that some users might want to manually check the 
Prometheus metrics or the service discovery endpoint, and they would face a 
breaking change: suddenly they would need to provide a bearer token.
Also, some folks might have Knox in the mix — no pun intended :D For example, 
Knox could be used to bridge the SPNEGO gap with Prometheus. However, this was 
not considered a first-class solution, since the current implementation does 
not require Knox.
So instead, I opted for allowing both SPNEGO and bearer token authentication on 
the Prometheus endpoints. Both methods work.


--
To view, visit http://gerrit.cloudera.org:8080/24278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8169196a2c49d64865095f3bc6da1d3bfbcecfb
Gerrit-Change-Number: 24278
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Wed, 13 May 2026 20:20:18 +0000
Gerrit-HasComments: No

Reply via email to