Marton Greber has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24373 )
Change subject: KUDU-3781: build 3rd-party Thrift with OpenSSL support
......................................................................
KUDU-3781: build 3rd-party Thrift with OpenSSL support
In the context of the JIRA ticket it's necessary to use TLS/SSL-related
entities in the Thrift C++ library, and those are available only
when configuring the library to be built with OpenSSL support.
This patch explicitly enables OpenSSL support for the Thrift
library by adding -DWITH_OPENSSL=ON for cmake invocation.
Also, add an extra flag to be explicit that the compiler supports
at least C++17 and remove obsolete -DWITH_PLUGIN macro.
P.S. I'm planning to update the library up to 0.23.0 version
in a follow-up changelist: there were multiple security
vulnerabilities published recently
Change-Id: If8bb4ad61b57546c3c0c9ced0f1b9b3aabac183c
Reviewed-on: http://gerrit.cloudera.org:8080/24373
Reviewed-by: Zoltan Chovan <[email protected]>
Tested-by: Zoltan Chovan <[email protected]>
Reviewed-by: Marton Greber <[email protected]>
---
M thirdparty/build-definitions.sh
1 file changed, 12 insertions(+), 9 deletions(-)
Approvals:
Zoltan Chovan: Looks good to me, approved; Verified
Marton Greber: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/24373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If8bb4ad61b57546c3c0c9ced0f1b9b3aabac183c
Gerrit-Change-Number: 24373
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
