Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24374 )
Change subject: KUDU-3781: Add TLS support to MiniHms ...................................................................... Patch Set 4: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/24374/2/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/24374/2/src/kudu/hms/mini_hms.cc@272 PS2, Line 272: return Status::OK(); : } : : // Clean up leftovers from an earlier failed attempt before invoking keytool. : for (const auto& path : tls_artifacts) { : if (env->FileExists(path)) { : RETURN_NOT_OK(env->DeleteFile(path)); : } : } : > I added the scoped cleanup, I'm wondering if a crash could prevent that als Thank you for addressing this. Manual removal of the artifacts looks like an overkill to me. If anything crashed, the related tests would fail from that point anyway, right? There is also a concern that the manual clean-up might cover up a bug, if there is any. I think we can keep the extra manual step as of PS4. I want to re-base my patches on top to have this functionality in mini-hms. We can address my concern later on -- it's not a big deal after all. http://gerrit.cloudera.org:8080/#/c/24374/2/src/kudu/hms/mini_hms.cc@303 PS2, Line 303: > Yes, HMS uses hive.metastore.keystore.password as the password passed into Thank you for the clarification and verifying it works as expected. http://gerrit.cloudera.org:8080/#/c/24374/2/src/kudu/hms/mini_hms.cc@511 PS2, Line 511: static const string kTlsEnabledConfigTemplate = R"( : <property> : <name>hive.metastore.use.SSL</name> : <value>true</value> : </property> > I'm just afraid of changing defaults, but we can go with omitting this part I see. OK, it works either way for me. I'm fine with what's in PS4, but feel free to change back to what was in PS2 if you see a real risk of changing those default settings. -- To view, visit http://gerrit.cloudera.org:8080/24374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fca647fd900fafc6d737c93a4af4565631839b7 Gerrit-Change-Number: 24374 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 17:11:10 +0000 Gerrit-HasComments: Yes
