Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24427 )
Change subject: [subprocess] Fix buffer over-read/overflow in message discard ...................................................................... Patch Set 1: Code-Review+2 Thank a lot for fixing the typo (std::max --> std::min) and adding the test scenarios. Finally, we have good tests that can catch regressions there, if any. I guess the bug/typo went unnoticed with the changelist that addressed KUDU-3450 because the added test scenarios were using artificially low settings for --subprocess_max_message_size_bytes. However, I'm not sure how it went unnoticed in the review :) A fun fact is that there were at least two reviewers who left feedback on the review item in gerrit, and it seems you were one of them: https://gerrit.cloudera.org/#/c/19500/ -- To view, visit http://gerrit.cloudera.org:8080/24427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73da816132555cb3d29b7bbf8a6821ad3f2dec9c Gerrit-Change-Number: 24427 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Jun 2026 19:57:48 +0000 Gerrit-HasComments: No
