Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24412 )
Change subject: KUDU-3429 Add extensive test for delta generation (3/n) ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/24412/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24412/1//COMMIT_MSG@13 PS1, Line 13: * Wide column data to make each mutation size big enough (1KB). Along : with repetitive updates ensures increased delta memory footprint. > kLargeValSizeBytes is 64 kb, or what size is this 1 KB? It should be 64kb, actually. Fixed. http://gerrit.cloudera.org:8080/#/c/24412/1/src/kudu/tablet/compaction-highmem-test.cc File src/kudu/tablet/compaction-highmem-test.cc: http://gerrit.cloudera.org:8080/#/c/24412/1/src/kudu/tablet/compaction-highmem-test.cc@161 PS1, Line 161: // > The docstring says "kFlushRounds = 10 * size_factor" but the implementation Done http://gerrit.cloudera.org:8080/#/c/24412/1/src/kudu/tablet/compaction-highmem-test.cc@505 PS1, Line 505: tablet()->GetRowSetsForTests(&rowsets); > `total_delta_bytes` is accumulated but never asserted on or logged. The com Done http://gerrit.cloudera.org:8080/#/c/24412/1/src/kudu/tablet/compaction-highmem-test.cc@535 PS1, Line 535: // Disable compaction memory budgeting for this rowset compaction op. > The comment says "Disable compaction memory budgeting" but the code sets th I am almost certain that I kept hitting 'out of budget' error when the flag was enabled, that caused filtering of the rowset from compaction. So, I intended to disable it for this run in order to achieve the goal of the unit test. However, I noticed that it is not the case anymore. My best guess is that I reduced size of generated deltas to avoid long running test, before I posted for review. With current size of ~40MB, we cannot hit the budget set in this test. So, there is no need to manipulate the flags. Removed the use. http://gerrit.cloudera.org:8080/#/c/24412/1/src/kudu/tablet/compaction-highmem-test.cc@539 PS1, Line 539: // Enable compaction memory budgeting for next tests. > The restore comment "Enable compaction memory budgeting for next tests." is Removed. -- To view, visit http://gerrit.cloudera.org:8080/24412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c337dba87a9d1cf549f9b53813da8d50e86b6b4 Gerrit-Change-Number: 24412 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2026 10:30:11 +0000 Gerrit-HasComments: Yes
