Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24109 )
Change subject: Fix TSAN data races in KuduScanner keep-alive callback ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/24109/8/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/24109/8/src/kudu/client/scanner-internal.cc@119 PS8, Line 119: keep_alive_proxy_ = proxy_; Shouldn't we reset keep_alive_proxy_ with every iteration of the periodic task? Otherwise, how is the periodic task (which is usually started with the very first tablet) going to send keep-alive requests to proper destination when proxy_ is updated upon calling KuduScanner::Data::OpenTablet()? Would be great to have a comment to clarify this, otherwise it looks like a bug. -- To view, visit http://gerrit.cloudera.org:8080/24109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b915879f717e6909e2d49b3bfa9360dd428cc89 Gerrit-Change-Number: 24109 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 21:45:53 +0000 Gerrit-HasComments: Yes
