Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24511 )
Change subject: KUDU-3787 Make tls_debug support Kerberos ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24511/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/24511/1/src/kudu/rpc/client_negotiation.cc@221 PS1, Line 221: // Diagnostic shortcut: when the caller only wants to observe the negotiated : // TLS parameters (e.g. `kudu diagnose tls_debug`), skip SASL/token/JWT : // authentication. The server will log an aborted negotiation when we : // disconnect, but the TLS-level info on the socket is fully populated. : if (tls_only_) { : TRACE("Stopping negotiation after TLS handshake (tls_only mode)"); : return Status::OK(); : } > It should never be up to the client to enforce security. Anyone can build a The point not about the client to enforce security. The point was about a situation when a client talks to a malicious server, assuming that the security is enforced by whatever side. -- To view, visit http://gerrit.cloudera.org:8080/24511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6c6c9ac1cebeab8cb48bd22aea852c93c0252a4 Gerrit-Change-Number: 24511 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2026 14:17:34 +0000 Gerrit-HasComments: Yes
