Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24517 )
Change subject: [java] Upgrade build to Gradle 9 ...................................................................... Patch Set 4: (2 comments) File: java/gradle/compile.gradle Line: 25 nit: The docs link `https://docs.gradle.org/7.6.4/dsl/...` references the old version. Consider updating to `https://docs.gradle.org/current/dsl/...` or the 9.1.0 equivalent so it doesn't drift again. http://gerrit.cloudera.org:8080/#/c/24517/4/java/build.gradle File java/build.gradle: http://gerrit.cloudera.org:8080/#/c/24517/4/java/build.gradle@86 PS4, Line 86: destinationDir = file("${buildDir}/docs/javadoc") nit: `buildDir` is deprecated in Gradle 9 (emits a deprecation warning at configuration time). The DistTestTask.java in this same patch already migrated to `project.layout.buildDirectory` -- for consistency, this could become `layout.buildDirectory.get().asFile` here and on line 107. Not blocking since it still works in 9.1, wdyt? http://gerrit.cloudera.org:8080/#/c/24517/4/java/gradle/shadow.gradle File java/gradle/shadow.gradle: http://gerrit.cloudera.org:8080/#/c/24517/4/java/gradle/shadow.gradle@65 PS4, Line 65: // Current Gradle version(7.6.4) used to compile Java projects of Kudu project doesn't support nit: should this be updated too? -- To view, visit http://gerrit.cloudera.org:8080/24517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I874d631ce7f4ca6527c9ffda6caef75c2976932d Gerrit-Change-Number: 24517 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 01 Jul 2026 10:33:49 +0000 Gerrit-HasComments: Yes
