Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24525 )
Change subject: KUDU-3789 auto_rebalancer: reliably clear replace marker after failed moves ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24525/1/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24525/1/src/kudu/master/auto_rebalancer.cc@262 PS1, Line 262: — > nit: Unicode em dash, here and in other places too. Done http://gerrit.cloudera.org:8080/#/c/24525/1/src/kudu/master/auto_rebalancer.cc@264 PS1, Line 264: ProcessPendingReplaceClears(); > Does it make sense to retry more than once? How are pending items considere 1. There are two layers of retry: a few quick inline attempts (100ms, then 200ms), and a fallback queue that retries every rebalancer loop. The queue is the durable part, so the inline retries are just an optimization to clear the marker sooner instead of waiting for the next loop. 2. They aren't, the pending list is only a "keep trying to clear this marker" to-do list. It's never read by the move-planning code (BuildClusterInfo / GetMoves). 3. They count as stayed. BuildClusterInfo only looks at where the replicas physically are. -- To view, visit http://gerrit.cloudera.org:8080/24525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia47698207612252bca3ec70fc090a37bd3f87809 Gerrit-Change-Number: 24525 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 03 Jul 2026 08:04:49 +0000 Gerrit-HasComments: Yes
