Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24545 )
Change subject: KUDU-3777: return HTTP 401 for bad SPNEGO headers ...................................................................... Patch Set 2: (1 comment) Thank you for working on this! http://gerrit.cloudera.org:8080/#/c/24545/2/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/24545/2/src/kudu/server/webserver.cc@711 PS2, Line 711: // FIX: Map both Unauthorized and InvalidArgument to 401 nit: could we drop or reword this comment? The FIX: prefix and "map both X and Y to 401" just restate the code. If anything, I think it's more useful to capture the why, e.g. "A malformed/unsupported Authorization header is a client auth error, not a server error." -- To view, visit http://gerrit.cloudera.org:8080/24545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e85a991c50cddeec76a2ab16a65b34fe3fee5c Gerrit-Change-Number: 24545 Gerrit-PatchSet: 2 Gerrit-Owner: Jeison Romero <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2026 08:16:41 +0000 Gerrit-HasComments: Yes
