Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24516 )
Change subject: KUDU-3759 Randomize the choice among equally skewed tables ...................................................................... Patch Set 1: Code-Review+1 (1 comment) one small note, otherwise looks good http://gerrit.cloudera.org:8080/#/c/24516/1/src/kudu/rebalance/rebalance_algo.cc File src/kudu/rebalance/rebalance_algo.cc: http://gerrit.cloudera.org:8080/#/c/24516/1/src/kudu/rebalance/rebalance_algo.cc@279 PS1, Line 279: equal_skew_tables.push_back(it->second); this would deep copy each tied table, and TableBalanceInfo embeds a std::multimap<int32_t, std::string> ServersByCountMap, the original avoided this and didn't copy anything, storing pointers would avoid the copy, e.g.: vector<const TableBalanceInfo*> equal_skew_tables; for (auto it = range.first; it != range.second; ++it) { equal_skew_tables.push_back(&it->second); } ..... The number of max-skew ties is usually small and this runs once per move, so the impact wouldn't be huge, so this is not a big problem imo. I'm fine with it staying like this. -- To view, visit http://gerrit.cloudera.org:8080/24516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39cc610843d222a3dd2615a26993aba544639b54 Gerrit-Change-Number: 24516 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 13:00:49 +0000 Gerrit-HasComments: Yes
