Jeison Romero has posted comments on this change. ( http://gerrit.cloudera.org:8080/24545 )
Change subject: KUDU-3777: return HTTP 401 for bad SPNEGO headers ...................................................................... Patch Set 6: Thanks for looking into this Attila and Gabriella. Just to give a quick update on the multiple patch sets: While looking into Attila's question about the HTTP status code, I realized that returning a 401 for the wrong-scheme case was missing the WWW-Authenticate: Negotiate challenge header required by RFC 7235. I added it, but my first few attempts were applied it a bit too broadly, which tripped up existing assertions in webserver-test.cc (explicitly expects no challenge header to be returned when a bad token is supplied). The latest patch set adds the header only for the InvalidArgument (wrong-scheme) case. Everything is now in sync, comment was updates as Gabriella suggested and all tests are passing. Let me know if this looks good to go! -- To view, visit http://gerrit.cloudera.org:8080/24545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e85a991c50cddeec76a2ab16a65b34fe3fee5c Gerrit-Change-Number: 24545 Gerrit-PatchSet: 6 Gerrit-Owner: Jeison Romero <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Jeison Romero <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 03:58:17 +0000 Gerrit-HasComments: No
