Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24476 )

Change subject: KUDU-3767 Add global leader awareness to auto leader rebalancer 
(Part 2)
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24476/3/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/24476/3/src/kudu/master/auto_leader_rebalancer.cc@450
PS3, Line 450: Status AutoLeaderRebalancerTask::RunGlobalLeaderRebalance(
> RF=1 leaders are intentionally counted as load (so the pass won't pile mova
Cool, thank you for adding the new test.


http://gerrit.cloudera.org:8080/#/c/24476/3/src/kudu/master/auto_leader_rebalancer.cc@491
PS3, Line 491:   const int64_t ceil_avg = (total_leaders + num_eligible - 1) / 
num_eligible;
> Well, it can't move endlessly, two things prevent that. One is that a leade
For the example above, I'm not sure how those two factors can prevent endless 
leadership oscillation, but maybe I'm missing something -- will need to take 
another look.

>From you side, did you have a chance to take a closer look at the example in 
>my earlier comment?



--
To view, visit http://gerrit.cloudera.org:8080/24476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d44761f6444ca1d1bf4fcee405d65d029e41980
Gerrit-Change-Number: 24476
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 09 Jul 2026 05:42:43 +0000
Gerrit-HasComments: Yes

Reply via email to