Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24606 )
Change subject: [codegen] fix build on macOS Tahoe with Xcode 26.x (x86_64) ...................................................................... [codegen] fix build on macOS Tahoe with Xcode 26.x (x86_64) Prior to this patch, attempts to build Kudu on macOS Tahoe 26.5.2 with CLANG from Xcode 26.3 on Intel CPU (x86_64) machines were failing with errors like below: [ 93%] Generating precompiled.ll In file included from src/kudu/codegen/precompiled.cc:39: In file included from src/kudu/common/rowblock.h:28: In file included from src/kudu/common/columnblock.h:27: In file included from src/kudu/common/types.h:20: In file included from thirdparty/installed/uninstrumented/include/c++/v1/cmath:308: In file included from thirdparty/installed/uninstrumented/include/c++/v1/math.h:300: /Applications/Xcode-26.3.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.2.sdk/usr/include/math.h:645:27: error: _Float16 is not supported on this target extern _Float16 __fabsf16(_Float16) __API_AVAILABLE(macos(15.0), ios(18.0), watchos(11.0), tvos(18.0)); I'm not sure this is very relevant, but at least offical Swift docs [1] state FLoat16 is avalable on macOS only for Apple silicon: On macOS, Float16 is only available when targeting Apple silicon. [1] https://developer.apple.com/documentation/swift/float16 Change-Id: Ieedac431c9c9cc023c3bcc87a8ac806ea966bb65 Reviewed-on: http://gerrit.cloudera.org:8080/24606 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Gabriella Lotz <[email protected]> Reviewed-by: Marton Greber <[email protected]> --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Verified Gabriella Lotz: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieedac431c9c9cc023c3bcc87a8ac806ea966bb65 Gerrit-Change-Number: 24606 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
