Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24583 )
Change subject: KUDU-3788 an option to use pre-built thirdparty artifacts ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24583/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24583/4//COMMIT_MSG@16 PS4, Line 16: * name of the component (cmake, protobuf, etc.) : * version of the component as in $KUDU_HOME/thirdparty/vars.sh : * OS name/flavor (redhat, ubuntu, macos, etc.) : * OS major and minor version (9.2, 24.04, 26.5, etc.) : * CPU architecture (x86_64, aarch64, etc.) : * build toolchain info: : ** compiler family (gcc, clang, etc.) : ** C++ compiler version in form <major>.<minor>' (13.3, 17.0, etc.) > Do the identifiers know about transitive dependencies? Nope, they don't. The idea is to rely on the dependencies as they are implicitly encoded in the build scripts/function in the thridparty of corresponding components. If all the components are built using one particular dependency chain, this works as expected. If the dependency chain changes, then it will be necessary to bump the versions of the components. Alternatively, we can introduce some extra suffix or tag if there is a necessity to maintain versions of particular dependency lineages. http://gerrit.cloudera.org:8080/#/c/24583/4/thirdparty/prebuilt-utils.sh File thirdparty/prebuilt-utils.sh: http://gerrit.cloudera.org:8080/#/c/24583/4/thirdparty/prebuilt-utils.sh@163 PS4, Line 163: # Building a variable in the xxx_NAME form: vars.sh contains corresponding : # versioned strings for all the 3rd-party components. : local version_var="${name}_VERSION" : local version="${!version_var}" : if [ -z "$version" ]; then : echo "ERROR: $version_var isn't defined: check vars.sh" >&2 : exit 1 : fi : echo ${component_name}-${version} > Does this handle applying an additional patch to a component (or changing i If the patch version is reflected in the value of the corresponding xxx_VERSION variable that's defined in $KUDU_HOME/thirdparty/vars.sh (e.g., GTEST_VERSION), then yes -- this does handle it. -- To view, visit http://gerrit.cloudera.org:8080/24583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55b5b99fcbe60eec3f6ae19fa4f2e335f361d143 Gerrit-Change-Number: 24583 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2026 20:26:34 +0000 Gerrit-HasComments: Yes
