Jeison Romero has posted comments on this change. ( http://gerrit.cloudera.org:8080/24637 )
Change subject: KUDU-3751: master steps down instead of crashing on catch-up timeout ...................................................................... Patch Set 2: > iwyu broke: > > [100%] Built target generated-headers > 2026-07-27 18:38:10,161 INFO: Checking 2 file(s)... > >>> Fixing #includes in > >>> '/home/jenkins-slave/workspace/build_and_test/src/kudu/master/catalog_manager-test.cc' > @@ -18,12 +18,14 @@ > #include "kudu/master/catalog_manager.h" > > #include <cstdint> > +#include <functional> > #include <memory> > #include <numeric> > #include <ostream> > #include <string> > #include <thread> > #include <type_traits> > +#include <utility> > #include <vector> > > #include <gflags/gflags_declare.h> > @@ -37,6 +39,8 @@ > #include "kudu/common/row_operations.pb.h" > #include "kudu/common/schema.h" > #include "kudu/common/wire_protocol.h" > +#include "kudu/consensus/consensus.pb.h" > +#include "kudu/consensus/raft_consensus.h" > #include "kudu/gutil/ref_counted.h" > #include "kudu/gutil/strings/substitute.h" > #include "kudu/master/master.h" > @@ -46,6 +50,7 @@ > #include "kudu/master/ts_descriptor.h" > #include "kudu/mini-cluster/internal_mini_cluster.h" > #include "kudu/tablet/ops/op_tracker.h" > +#include "kudu/tablet/tablet_replica.h" > #include "kudu/util/cow_object.h" > #include "kudu/util/logging_test_util.h" > #include "kudu/util/monotime.h" > IWYU would have edited 1 files on your behalf. > > make[3]: *** [CMakeFiles/iwyu] Error 1 > CMakeFiles/iwyu.dir/build.make:70: recipe for target > 'CMakeFiles/iwyu' failed > make[2]: *** [CMakeFiles/iwyu.dir/all] Error 2 > CMakeFiles/Makefile2:2052: recipe for target 'CMakeFiles/iwyu.dir/all' > failed > make[1]: *** [CMakeFiles/iwyu.dir/rule] Error 2 > CMakeFiles/Makefile2:2059: recipe for target 'CMakeFiles/iwyu.dir/rule' > failed > make: *** [iwyu] Error 2 > Makefile:387: recipe for target 'iwyu' failed Thanks for taking a look into it Abhishek! I corrected the includes and sent the patch again. -- To view, visit http://gerrit.cloudera.org:8080/24637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9c5a3a6ec43c5174f8d8e92e2421029c51ea01 Gerrit-Change-Number: 24637 Gerrit-PatchSet: 2 Gerrit-Owner: Jeison Romero <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Jeison Romero <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 00:55:47 +0000 Gerrit-HasComments: No
