Jeison Romero has posted comments on this change. ( http://gerrit.cloudera.org:8080/24637 )
Change subject: KUDU-3751: master steps down instead of crashing on catch-up timeout ...................................................................... Patch Set 5: > (2 comments) Initially I tried switching to ASSERT_EVENTUALLY polling consensus->CurrentTerm(), but that actually surfaced a bug: in this single-voter config, the node's own failure detector can independently trigger reelections on its own schedule, advancing the term for reasons unrelated to the fix. Now, I modified the test a little bit: a small WaitableLogSink (mutex-protected send()/query) that lets ASSERT_EVENTUALLY safely poll for the actual log message we care about, rather than an indirect proxy like term count. I think you're right. NOT_THE_LEADER is a legitimate benign outcome, StepDown() returns Status::OK() with that error code when we're already not leader by the time we call it (e.g., another peer's failure detector could independently trigger a leadership change in that window). Updated to skip logging in that specific case, keeping the warning for genuine step-down failures. -- To view, visit http://gerrit.cloudera.org:8080/24637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9c5a3a6ec43c5174f8d8e92e2421029c51ea01 Gerrit-Change-Number: 24637 Gerrit-PatchSet: 5 Gerrit-Owner: Jeison Romero <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Jeison Romero <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 17:59:05 +0000 Gerrit-HasComments: No
