Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24591 )
Change subject: KUDU-3789 Deflake auto_leader_rebalancer-test ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24591/2/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/24591/2/src/kudu/master/auto_leader_rebalancer-test.cc@118 PS2, Line 118: // Restore the default in case a test bumped it (gflags are process global, q: This manual reset (and the whole "reset in TearDown so failover-based tests are unaffected under reordering" motivation in the commit message) looks redundant. KuduTest holds a google::FlagSaver constructed in its ctor and reset in its dtor (test_util.cc:124,172), so every gflag is already restored to its pre-test value after each TEST_F. Is there a case FlagSaver doesn't cover here? If not, this line could be dropped. If we keep it as belt-and-suspenders, note that hardcoding 3.0 duplicates the DEFINE_double default in raft_consensus.cc:81 and would silently go stale if that default ever changes -- capturing/restoring via google::FlagSaver locally (or just relying on the base-class one) avoids the magic number. -- To view, visit http://gerrit.cloudera.org:8080/24591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00224fddfead0fb462e793f085d935b597792aaa Gerrit-Change-Number: 24591 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 12:54:40 +0000 Gerrit-HasComments: Yes
