Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24646 )
Change subject: KUDU-3775: relax entity type restriction in Prometheus labels ...................................................................... Patch Set 1: (1 comment) Thanks for working on this! Just one comment nit, otherwise looks good to me. http://gerrit.cloudera.org:8080/#/c/24646/1/src/kudu/util/prometheus_writer.h File src/kudu/util/prometheus_writer.h: http://gerrit.cloudera.org:8080/#/c/24646/1/src/kudu/util/prometheus_writer.h@78 PS1, Line 78: // Build Prometheus label string for table/tablet entities. nit: this comment ("Build Prometheus label string for table/tablet entities") is now stale after the rename -- the function is generic. Suggest updating to reflect that it handles any non-server entity type, matching the new .cc comment. -- To view, visit http://gerrit.cloudera.org:8080/24646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23479bc3fb3c6f2ea81fd2b1727dd2bd1609a30c Gerrit-Change-Number: 24646 Gerrit-PatchSet: 1 Gerrit-Owner: Jeison Romero <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2026 11:19:12 +0000 Gerrit-HasComments: Yes
