Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24618 )
Change subject: KUDU-3734 Compaction budget refinements and observability ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24618/2/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/24618/2/src/kudu/tablet/tablet_metrics.cc@447 PS2, Line 447: A non-zero value is expected in " : "normal operation; a persistent rising rat > a persistent rising rate together with a high average_diskrowset_height or a > non-zero compaction_budget_skip_health gauge may indicate the budget is too > restrictive >From the user perspective, how can they gauge 'persistent rising rate'? IIUC, >in a wide variety of workloads this metric will always rise because of skipped >rowsets that turned to be less preferable compared to others at a particular >pass of the algorithm. Why to have such a metric then? It pretends to >provide a good signal on attempts to overspend the compaction budget, but in >fact it's not. I don't see value in adding such a noisy metric, but maybe I'm >missing something here. http://gerrit.cloudera.org:8080/#/c/24618/3/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/24618/3/src/kudu/tablet/tablet_metrics.cc@446 PS3, Line 446: , either nit: this part seems to be stale after the recent update in PS3 -- To view, visit http://gerrit.cloudera.org:8080/24618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id63db0006c77ad1d55eb2119d99ee64499435819 Gerrit-Change-Number: 24618 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 01 Aug 2026 04:11:45 +0000 Gerrit-HasComments: Yes
