Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20470
to look at the new patch set (#4).
Change subject: WIP [cfile] introduce BP128 integer encoding
......................................................................
WIP [cfile] introduce BP128 integer encoding
This changelist introduces support for BP128 encoding for Kudu integer
types at the server side. Essentially, this changelist cleans up and
ports Todd's patch [1] (which seems to be based on [2]) to the current
Kudu codebase with additional templatizing and removing the extra code
generation step that used to be implemented with gen_bitpacking.py.
The extra templatized step was performed with the help of
Cursor 3.7.36 (Composer 2.5 model).
NOTE: BP128 isn't supported for INT128 type yet.
The client-side support (C++ and Java) isn't a part of this changelist.
Other missing pieces include extending BP128 support for the INT128 type
and adding performance tests. All these and other extra steps are better
to be done in separate changelists for cleaner logical separation and
ease of code reviewing.
[1] https://github.com/toddlipcon/kudu/commit/9c0fd08e5
[2] https://github.com/lemire/SIMDCompressionAndIntersection
Change-Id: I07088a39907f0904846104b4d1d272a5968875e2
---
M src/kudu/cfile/CMakeLists.txt
A src/kudu/cfile/bitpacking-dispatch.h
A src/kudu/cfile/bitpacking-internal.h
A src/kudu/cfile/bitpacking-test.cc
A src/kudu/cfile/bitpacking-unroller.h
A src/kudu/cfile/bitpacking.h
A src/kudu/cfile/bp128_block.cc
A src/kudu/cfile/bp128_block.h
M src/kudu/cfile/encoding-test.cc
A src/kudu/cfile/simd_bitpacking-inl.h
A src/kudu/cfile/simd_bitpacking.h
M src/kudu/cfile/type_encodings.cc
M src/kudu/common/common.proto
13 files changed, 2,039 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/20470/4
--
To view, visit http://gerrit.cloudera.org:8080/20470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07088a39907f0904846104b4d1d272a5968875e2
Gerrit-Change-Number: 20470
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
