Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24584 )
Change subject: KUDU-3789 auto_rebalancer: de-flake TSAN tests ...................................................................... KUDU-3789 auto_rebalancer: de-flake TSAN tests A handful of tests in auto_rebalancer-test were flaky under TSAN dist-test. These are test-only fixes; there are no production changes. - OnlyLeaderDoesAutoRebalancing / NextLeaderResumesAutoRebalancing: instead of asserting non-leader masters have exactly 0 iterations, check that only the current leader's counts grow over a stable leadership window. The initial election can flicker, so a brief transient leader could have a non-zero count. - NoRebalancingIfReplicasRecovering / TestDeletedTables: wait until the master actually sees the killed tserver as dead (WaitForLiveTServerCount) rather than sleeping a fixed interval, set the unresponsive timeout only after the tables exist, and use RF=1 for the extra table. - PreferFollowerRebalancingTest / TestMaxMovesPerServer: give CheckSomeMovesScheduled more time under TSAN (and a lighter workload for the former), so the first scheduling round isn't cut off. - ExecuteMovesCASRejectionDropsMoveGracefully: retry until the CAS-rejection race we want to exercise actually happens, since a heartbeat can refresh the catalog's opid before ExecuteMoves runs. - RebalancerMetricsFollowerMoves: relax the leader-move count from ==0 to <= follower moves. prefer_follower is only a preference, so the rebalancer can still fall back to a leader move when the source has no follower for the table. Change-Id: I223f83be1db6f843f24a7bf95e31f3e3f77dcfe7 Reviewed-on: http://gerrit.cloudera.org:8080/24584 Reviewed-by: Marton Greber <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/master/auto_rebalancer-test.cc 1 file changed, 176 insertions(+), 110 deletions(-) Approvals: Marton Greber: Looks good to me, approved Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I223f83be1db6f843f24a7bf95e31f3e3f77dcfe7 Gerrit-Change-Number: 24584 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
