Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline ...................................................................... remove std::move on optional<MonoTime> deadline MonoTime wraps a single int64_t, so std::move on the deadline does nothing beyond a plain copy. clang-tidy flags these sites in rebalancer_tool.cc as performance-move-const-arg; drop the std::move. No behavior change. Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad Reviewed-on: http://gerrit.cloudera.org:8080/24680 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tools/rebalancer_tool.cc 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad Gerrit-Change-Number: 24680 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]>
