Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24681 )

Change subject: [dist-test] Fix chrpath ETXTBSY race in dist slaves
......................................................................


Patch Set 3:

(1 comment)

q: If we are holding a write lock on it, wont the run fail on the other side 
with certain timing? (With a much smaller chance, because unlike execution, the 
chrpath takes a really short time).

http://gerrit.cloudera.org:8080/#/c/24681/3/build-support/run_dist_test.py
File build-support/run_dist_test.py:

http://gerrit.cloudera.org:8080/#/c/24681/3/build-support/run_dist_test.py@122
PS3, Line 122:       os.rename(tmp_path, path)
nit: os.replace maybe?
rename is platform dependent (this would fail on windows with file already 
exist).
replace is the platform independent function for what you are doing here.



--
To view, visit http://gerrit.cloudera.org:8080/24681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80cdc5b903f5ed0865ec5a92f905a46719f7e316
Gerrit-Change-Number: 24681
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 12:39:20 +0000
Gerrit-HasComments: Yes

Reply via email to