Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24679 )
Change subject: KUDU-3795 Fix ENOSPC on dist-test due to compaction tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24679/2/src/kudu/tablet/compaction-highmem-test.cc File src/kudu/tablet/compaction-highmem-test.cc: http://gerrit.cloudera.org:8080/#/c/24679/2/src/kudu/tablet/compaction-highmem-test.cc@a555 PS2, Line 555: : : With this removed, what's the point of keeping the HighDeltaVolumeWithFrequentFlushForRowsetCompaction scenario around? Wouldn't it make sense to clamp hard memory limit much lower, so compaction activity still reaches beyond the newly customized threshold? http://gerrit.cloudera.org:8080/#/c/24679/2/src/kudu/tablet/compaction-highmem-test.cc@504 PS2, Line 504: build nit: test? Also, this might be an overstatement: with high enough concurrency level and very limited space in the filesystem that backs the temporary directory, it's going to run out of space :) -- To view, visit http://gerrit.cloudera.org:8080/24679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38df827a72626840a4da49e8a7b9d7f699525555 Gerrit-Change-Number: 24679 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 13 Aug 2026 18:24:37 +0000 Gerrit-HasComments: Yes
