Gabriella Lotz has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/24694


Change subject: KUDU-3791 add metrics for auto-leader-rebalancer
......................................................................

KUDU-3791 add metrics for auto-leader-rebalancer

Before this change, log grepping was the only way to see what the
auto-leader-rebalancer was doing. Add four counters on the master
so operators and tests can observe it:

- auto_leader_rebalancer_moves_scheduled
- auto_leader_rebalancer_moves_failed
- auto_leader_rebalancer_rounds_completed
- auto_leader_rebalancer_global_pass_skipped

Naming and units mirror the counters AutoRebalancerTask already
exposes, so the two tasks read as a matched pair on /metrics.

The last counter closes a diagnosability gap of its own. The global
corrective pass only runs on rounds where per-table balancing has
nothing left to schedule. If per-table work keeps arriving every
round, the global pass never runs, and this counter is the signal.

The AutoLeaderRebalancerTask constructor now takes a MetricEntity,
passed from CatalogManager the same way AutoRebalancerTask already
does. Adds a LeaderRebalancerTest.RebalancerMetrics test that
exercises all four counters.

Leaves the pre-existing "make step-down RPCs async" TODO in place
as a separate follow-up.

Change-Id: I49b86e59043a7f652d4f556b94582bb74c5698ad
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/auto_leader_rebalancer.h
M src/kudu/master/catalog_manager.cc
4 files changed, 154 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/24694/1
--
To view, visit http://gerrit.cloudera.org:8080/24694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49b86e59043a7f652d4f556b94582bb74c5698ad
Gerrit-Change-Number: 24694
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <[email protected]>

Reply via email to