Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24704 )

Change subject: KUDU-3800: Make SetDiffscan() API available to clients
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24704/1//COMMIT_MSG
Commit Message:

PS1:
Is there any particular reason to have this as a separate changelist from 
https://gerrit.cloudera.org/#/c/24578/?


http://gerrit.cloudera.org:8080/#/c/24704/1/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/24704/1/src/kudu/client/client.h@3182
PS1, Line 3182:       DiffScanRowVisibility visibility) WARN_UNUSED_RESULT;
What about KuduScanTokenBuilder API?  Why do we want to keep similar method as 
non-exported there?



--
To view, visit http://gerrit.cloudera.org:8080/24704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd64cb0fd150f52b793e48279bbcba9ea0c3e266
Gerrit-Change-Number: 24704
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Comment-Date: Tue, 18 Aug 2026 03:07:10 +0000
Gerrit-HasComments: Yes

Reply via email to