Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24683 )
Change subject: KUDU-3761 prefer follower moves cross-location ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo-test.cc@1684 PS5, Line 1684: // LocationBalancingAlgo must prefer a source that hosts a non-leader replica > Do you think an integration test is also required to test the end-to-end fu There's already RebalancePreferFollowerTest in rebalancer_tool-test.cc, which runs the tool end-to-end with --prefer_follower_replica_moves in both settings. As its comment notes, it's a wiring check and doesn't assert the follower preference itself. I think doing that at the CLI layer would be hard without flakiness since leader placement isn't deterministic in a live cluster, and the preference itself is already covered by the algorithm-level tests here. http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo.h File src/kudu/rebalance/rebalance_algo.h: http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo.h@313 PS5, Line 313: bool prefer_follower_moves); > Do you think it would make sense to force callers to provide the value expl Good point, I've dropped the default. Both production callers already pass the flag explicitly, and the one test relying on the default has been updated. -- To view, visit http://gerrit.cloudera.org:8080/24683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a162a227071caf37d572ba60c2bc49608d14e65 Gerrit-Change-Number: 24683 Gerrit-PatchSet: 6 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 09:01:08 +0000 Gerrit-HasComments: Yes
