Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24779 )
Change subject: [metrics] Support merge_rules aggregation in /metrics_prometheus ...................................................................... [metrics] Support merge_rules aggregation in /metrics_prometheus The /metrics_prometheus endpoint now supports the same entity merging that the /metrics JSON endpoint has offered for years, so that per-tablet metrics can be aggregated into per-table (or any user-defined) entities before being exported. On clusters with a large number of tablets this drastically cuts down the number of exported Prometheus time series, which is the dominant source of cardinality pressure when scraping Kudu natively. Merging is requested either per-request via the 'merge_rules' query parameter (identical syntax to the JSON endpoint, e.g. ?merge_rules=tablet|table|table_name), or server-wide via the new --metrics_prometheus_default_merge_rules flag, which is applied whenever a request does not carry its own 'merge_rules'. A request parameter takes precedence over the flag. Change-Id: I76a365de3b328f2beefd460626cc0c896537e713 Reviewed-on: http://gerrit.cloudera.org:8080/24779 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/server/default_path_handlers.cc M src/kudu/util/metrics-test.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h M src/kudu/util/prometheus_writer.cc M src/kudu/util/prometheus_writer.h 6 files changed, 497 insertions(+), 16 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I76a365de3b328f2beefd460626cc0c896537e713 Gerrit-Change-Number: 24779 Gerrit-PatchSet: 3 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]>
