Hello Marton Greber,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/24813
to review the following change.
Change subject: Fix PostgreSQL 17.2 build on macOS: don't detect memset_s().
......................................................................
Fix PostgreSQL 17.2 build on macOS: don't detect memset_s().
macOS ships memset_s() in libSystem, so PostgreSQL's AC_CHECK_FUNCS link
test succeeds and configure defines HAVE_MEMSET_S. However, the
declaration in <string.h> is gated behind __STDC_WANT_LIB_EXT1__ (C11
Annex K), so at compile time src/port/explicit_bzero.c fails with an
implicit-function-declaration error under -Werror.
The simplest fix (and analogous to the strchrnul() workaround already
carried) is to drop memset_s from the AC_CHECK_FUNCS list. PostgreSQL's
explicit_bzero.c has a portable fallback (indirect call through a
volatile pointer to plain memset) that will be used when HAVE_MEMSET_S
is undefined.
Change-Id: I230d71ba4b8cc6d5dc9afb4e8bd45d8c523b246b
---
A thirdparty/patches/postgres-fix-memset_s-macos-check.patch
M thirdparty/vars.sh
2 files changed, 37 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/24813/1
--
To view, visit http://gerrit.cloudera.org:8080/24813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I230d71ba4b8cc6d5dc9afb4e8bd45d8c523b246b
Gerrit-Change-Number: 24813
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Marton Greber <[email protected]>
