Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )
Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG@22 PS1, Line 22: This was harmless while the client's bundled protobuf matched the host : application's protobuf version, but after bumping protobuf to 3.21.9 for : GCC-15 support (KUDU-3803) I'm not sure this makes sense to me. The updates made in the context of KUDU-3803 didn't change anything for protobuf compilation in Kudu's thirdparty. Also, Kudu has upgraded protobuf in 3rd-party more than 1.5 year ago (February 2025), so the mismatch between Kudu's protobuf and Impala's protobuf has been there for a while. Is this an AI slop or I'm missing something? http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map File src/kudu/client/symbols.map: http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map@37 PS1, Line 37: descriptor_table_google_2fprotobuf_2f*; So, where does this belong? Why is this here and under C++ section as well? This doesn't make sense to me. http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map@48 PS1, Line 48: *google::protobuf::MapKey*; Isn't this covered already by pattern at line 41? -- To view, visit http://gerrit.cloudera.org:8080/24851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d Gerrit-Change-Number: 24851 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 17:44:21 +0000 Gerrit-HasComments: Yes
