Hello Zoltan Martonka, Kudu Jenkins, Abhishek Chennaka, Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24862
to look at the new patch set (#2).
Change subject: KUDU-3805 prefer using mold linker when available
......................................................................
KUDU-3805 prefer using mold linker when available
This changelist enables using the mold linker [1] for building Kudu
and addresses KUDU-3614 as well.
With the mold linker, it was necessary to switch to using --exclude-libs
for gflags and glog libraries to avoid exporting their symbols.
It seems the mold linker doesn't recognize and interpret the *google::*
pattern the same way as a GNU ld-compatible linker does. With that,
I removed corresponding sections from src/kudu/client/symbols.map.
Maybe, we need to eventually switch to using --exclude-libs=ALL and
avoid using the --version-script provisions, but it's a separate story.
[1] https://github.com/rui314/mold
Change-Id: I9cd76b3cfa96b6ebd119a95d24834fe154e56aa0
---
M cmake_modules/KuduLinker.cmake
M src/kudu/client/CMakeLists.txt
M src/kudu/client/symbols.map
3 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/24862/2
--
To view, visit http://gerrit.cloudera.org:8080/24862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9cd76b3cfa96b6ebd119a95d24834fe154e56aa0
Gerrit-Change-Number: 24862
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
