Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24836 )
Change subject: [metrics] add --metrics_prometheus_default_metrics for a server-side allowlist ...................................................................... Patch Set 2: (2 comments) > Patch Set 1: Code-Review+1 > > (2 comments) > > Just two questions from my side, otherwise looks good to me. > Thank you for working on this! Thanks for the review. PTAL when you have time. The IWYU failure on pre_commit #2995 looks like an environment issue, not related to this patch. http://gerrit.cloudera.org:8080/#/c/24836/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/24836/1/src/kudu/util/metrics.cc@212 PS1, Line 212: if (value.empty()) { : return true; : } : vector<string> tokens; : SplitStringUsing(value, ",", &tokens); > The validator warns when the value collapses to zero tokens (,,), which is Done http://gerrit.cloudera.org:8080/#/c/24836/1/src/kudu/util/metrics.cc@381 PS1, Line 381: ParseQuantiles(default_quantiles, quantiles); > ParseArray on a present-but-empty ?metrics= returns an empty vector, so thi Correct, this is intentional. Treating a present-but-empty ?metrics= the same as "no param passed" is deliberately consistent with the quantiles/merge_rules siblings. So once the default flag is set, a scrape can't request the full metric set via an empty ?metrics=. -- To view, visit http://gerrit.cloudera.org:8080/24836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70ef54eef456108f8503a4edfdfb68fab3173353 Gerrit-Change-Number: 24836 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Sun, 20 Sep 2026 03:56:07 +0000 Gerrit-HasComments: Yes
