Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves ...................................................................... Patch Set 2: (3 comments) Thank you addressing this. Overall looks good to me. Just a few nits/questions. http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc@221 PS2, Line 221: /*prefer_follower_moves=*/true Don't see any unit test with 'prefer_follower_moves=false'. Any reason for that? http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h File src/kudu/rebalance/rebalance_algo.h: http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h@a198 PS2, Line 198: question - Why not keep this, to prevent implicit conversion from braced initializer lists - {arg1, arg2} ? LocationBalancingAlgo has the keyword. http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo.h@198 PS2, Line 198: TwoDimensionalGreedyAlgo(EqualSkewOption opt, : bool prefer_follower_moves); nit: Maybe add a comment above providing guidance on impact of both arguments on the algorithm, now that there are no default values. -- To view, visit http://gerrit.cloudera.org:8080/24863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035 Gerrit-Change-Number: 24863 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2026 07:30:08 +0000 Gerrit-HasComments: Yes
