Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24618 )
Change subject: KUDU-3734 Compaction budget refinements and observability ...................................................................... Patch Set 11: (1 comment) > (1 comment) > > No test in the patch exercises any new behavior. Something like: > > - compaction_policy-test: with an oversized candidate present, > assert compaction_budget_skip_health flips to 1; then GC/shrink it > (or hit the asc_max_key.empty() early return) and assert it resets > to 0. > - rowset_info unit check that --rowset_undo_deltas_budget_weight > (e.g. 0.0, 0.5, 1.0) scales base_and_deltas_size_mb() as expected, > and the clamp above holds when undo >= total. > - A ts_tablet_manager / metrics test that > tablets_num_compaction_budget_degraded > counts only RUNNING replicas with the gauge set. > > What do you think? Oops! I totally missed out on adding the test file. I have all the test coverage in a new file that I forgot to 'git add'. Thanks for catching this. Let me update the patch with all the existing tests as well as the test coverage you suggested (if applicable). http://gerrit.cloudera.org:8080/#/c/24618/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24618/11//COMMIT_MSG@84 PS11, Line 84: tablet_compaction_budget_mb > Maybe this is not pressing for this particular change, but is --tablet_comp Flag value change requires a tablet server restart. It gets populated into size_budget_mb_ at the time of tablet initialization. After that, it is always read from the variable and not from FLAGS_tablet_compaction_budget_mb directly. There is some merit in making it runtime in the long run, to avoid any downtime and also speedup the tuning of budget. Let me post a separate patch for that. -- To view, visit http://gerrit.cloudera.org:8080/24618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id63db0006c77ad1d55eb2119d99ee64499435819 Gerrit-Change-Number: 24618 Gerrit-PatchSet: 11 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 06:35:52 +0000 Gerrit-HasComments: Yes
